Closed
Conversation
Small refactoring to make contextify more readable. Remove auto and inline FromJust(). Simplify if statement.
nodejs-github-bot
added
the
c++
Member
Author
bnoordhuis
approved these changes
Oct 3, 2016
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
You can have my LGTM if you want it but I consider style changes mostly needless churn.
The readability argument is debatable; I personally don't find redundant type info more readable but different strokes for different folks.
Member
Member
|
It appears unrelated, but there's a bit too much red in that last CI run, trying again: https://ci.nodejs.org/job/node-test-pull-request/4420/ |
fhinkel
added a commit
that referenced
this pull request
Oct 16, 2016
Small refactoring to make contextify more readable. Remove auto and inline FromJust(). Simplify if statement. PR-URL: #8909 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
Author
|
Landed in f7842ad |
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2016
Small refactoring to make contextify more readable. Remove auto and inline FromJust(). Simplify if statement. PR-URL: #8909 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Contributor
|
@fhinkel should this be backported? |
Member
Author
|
No. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX) passesAffected core subsystem(s)
src, vm
Description of change
Small refactoring to make contextify more readable.
Remove
autoand inlineFromJust(). Simplifyifstatement.